Improve stack trace formatting

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.

https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/

MIT License

19.08k stars 4.04k forks source link

Improve stack trace formatting #5250

Open tmat opened 9 years ago

tmat commented 9 years ago

This is used in REPLs to display stack frames.

amcasey commented 8 years ago

Part of https://github.com/dotnet/roslyn/issues/6887

amcasey commented 8 years ago

[x] Improve ObjectFormatter.FormatMethodSignature
[ ] Drop submission type names
[x] Drop infrastructure (e.g. host) frames

ManishJayaswal commented 8 years ago

Can we use line number instead of submission number? We can turn line numbers on by default in interactive and use that. That would be more intuitive to the users.

tmat commented 8 years ago

Turning line numbers on is a good idea. But we don't need to display them instead of submission numbers. Stack frames should already include line numbers (and file names) in their display strings for regular files. We'll need an infrastructure that propagates the line number from the host thru the hosting APIs to the emitter though. We don't have such infrastructure currently. I have filed an issue (#7723) because having it would be really useful.

amcasey commented 8 years ago

Exception stack traces have been improved but we still need to do work around dropping submission names and (optionally?) showing line numbers. The remaining work doesn't meet the bar for 1.2.