search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
19.07k stars 4.04k forks source link

Unify SettingsUpdateHelper and ConfigurationUpdater implementation #52735

Closed jmarolf closed 3 weeks ago

mavasani commented 3 years ago

RE: Are there tests for ConfigurationUpdater?

There are no direct unit tests for this compoment, but it is thoroughly tested from the unit tests for Configure Severity and Configure Option lightbulb actions: https://github.com/dotnet/roslyn/tree/main/src/EditorFeatures/CSharpTest/Diagnostics/Configuration

jmarolf commented 2 years ago

Should ensure that we normalize the way line endings are added as part of this. I like @Youssef1313's suggested behavior here: https://github.com/dotnet/roslyn/pull/58075#discussion_r761348136

jmarolf commented 2 years ago

related to https://github.com/dotnet/roslyn/issues/54556

CyrusNajmabadi commented 3 weeks ago

Closing out as speculative.