search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.96k stars 4.02k forks source link

Compilers generated code isn't validated in CI when only source generators are changed #65602

Open Youssef1313 opened 1 year ago

Youssef1313 commented 1 year ago

Validation is conditioned on compilerChange being true here:

https://github.com/dotnet/roslyn/blob/35ac8cb689bebf24cb977121a6539e47789b4351/azure-pipelines.yml#L237-L245

which is run only if there are changes to src\Compilers or src\Dependencies:

https://github.com/dotnet/roslyn/blob/35ac8cb689bebf24cb977121a6539e47789b4351/azure-pipelines.yml#L206-L208

If a PR has changes only to the generators, the validation will be incorrectly skipped

jasonmalinowski commented 1 year ago

@jmarolf It looks like that condition might go back to https://github.com/dotnet/roslyn/pull/62797 -- is just adding the additional folder to the list that was called out here sufficient, or does more work need to be done? I don't mind sending out the PR if it's a trivial fix but if this takes more work I'm not sure if you should pick this one up? (Or I'll need some explanation of how it works!)