sharwell
commented
1 year ago 📝 note that the code refactoring infrastructure automatically adjusts line endings by default. If the refactoring is producing mixed line endings, it means the refactorings has produced code changes that explicitly removed the elastic and formatting annotations to instruct the infrastructure to not alter the specific contents of the change, even if those changes fail to adhere to the style. When fixing this issue, the best place to start is a new parameterized unit test that runs the same refactoring on a source file, once with the file set to LF line endings and a second time with the file set to CRLF line endings. When fixing this issue, note the following:
- If possible, use elastic line endings in code produced by the refactoring. When using these, it is not necessary to adjust for LF/CRLF configurations.
- If non-elastic trivia is required due to some other limitation, the .editorconfig settings SHOULD NOT be used. Instead, the refactoring should reproduce the line endings already present in the file at the point of text insertion.
This issue has been moved from a ticket on Developer Community.
[severity:It's more difficult to complete my work] If you select some code (in C#, Javascript or Typescript) and use one of the refactoring helper functions which would extract the code and add any new lines would not adhere to the editorconfig settings which may be set to LF, instead the new lines are added as CRLF which causes mixed line ending issues.
Original Comments
Feedback Bot on 8/22/2022, 09:51 PM:
(private comment, text removed)
Feedback Bot on 12/1/2022, 00:55 AM:
(private comment, text removed)
Sam Harwell on 4/10/2023, 09:31 AM:
Hi Dan Petitt,
Note that every refactoring is responsible for its own behavior. Based on the recording provided, I’ve narrowed this issue to specifically refer to the behavior of the C# Extract Method refactoring and assigned it to that team.
Thank you,
Sam Harwell
Original Solutions
(no solutions)