search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
19.04k stars 4.03k forks source link

Replace GitHub automation for requiring reviews of PRs that cange the .NET SDK version #71275

Open jeffhandley opened 10 months ago

jeffhandley commented 10 months ago

This repository has had automation in place that prevents auto-merge of PRs that change the .NET SDK version. That automation was implemented through the Fabric Bot tooling with the following logic:

  1. When a pull request is opened
  2. If the body of the pull requst contains the string, "Updates sdk.version"
  3. And the author of the PR is "dotnet-maestro[bot]"
  4. Then issue the action of requiring changes to the pull request, leaving the following comment
This PR changes the .NET SDK version. Review required from @dotnet/roslyn-infrastructure-current-swat before merging.
Tasks:
- [ ] Getting Started Documentation has been updated
- [ ] NuGet dependency version updated to match version shipping in SDK

We need to remove this automation as our migration from Fabric Bot to the Policy Service Resource Management tooling will not support the automated action of requesting changes to a pull request.

After the migration to the new service is completed, we can reintroduce this automation, perhaps with the approach of using the same logic as above, but issuing the action of disabling auto-merge, either through removing the label or using GitHub's built-in auto-merge and disabling that.

/cc @arkalyanms @wtgodbe @mkArtakMSFT @jaredpar

wtgodbe commented 9 months ago

@arkalyanms @jaredpar what bot currently auto-merges PRs in this repo?