search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.7k stars 3.98k forks source link

Account for partial properties at existing use sites of partial method symbol APIs #73772

Open RikkiGibson opened 1 month ago

RikkiGibson commented 1 month ago

Test plan: #73090

Issue referenced in source

Compilers

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerManager.AnalyzerExecutionContext.cs#L206-L212

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilationWithAnalyzers.cs#L1111-L1125

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Compilers/Core/Portable/Emit/SemanticEdit.cs#L145-L154

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Compilers/Core/Portable/Emit/EditAndContinue/SymbolChanges.cs#L415-L426

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs#L2766-L2768

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.Variables.cs#L399-L400

IDE

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Analyzers/CSharp/CodeFixes/Nullable/CSharpDeclareAsNullableCodeFixProvider.cs#L234-L240

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs#L3188-L3193

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs#L3357-L3359

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs#L3671-L3672

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Features/Core/Portable/Completion/Providers/AbstractPartialMethodCompletionProvider.cs#L93-L96

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Features/Core/Portable/EditAndContinue/Utilities/Extensions.cs#L186-L188

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Features/TestUtilities/EditAndContinue/EditAndContinueTestVerifier.cs#L325-L331

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Workspaces/CSharp/Portable/Rename/CSharpRenameRewriterLanguageService.cs#L827-L833

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Workspaces/Core/Portable/Rename/ConflictEngine/DeclarationConflictHelpers.cs#L58-L66

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Workspaces/Core/Portable/FindSymbols/FindReferences/Finders/OrdinaryMethodReferenceFinder.cs#L37-L42

https://github.com/dotnet/roslyn/blob/f242061ebdb94b2544a297a2666e14ce81ab9c7c/src/Workspaces/Core/Portable/FindSymbols/FindReferences/Finders/ParameterSymbolReferenceFinder.cs#L244-L253

RikkiGibson commented 1 month ago

I just reviewed this list, I think all the comments listed in the issue are still present in source.

Cosifne commented 1 month ago

I am working on the IDE part. Most of them need some changes.

RikkiGibson commented 1 month ago

Removed entries which were resolved by #73792