Closed lonix1 closed 1 month ago
CyrusNajmabadi
commented
2 months ago VBCSCompiler is likely roslyn.
Could you give some examples of what are in;
It will help track down the relevant teams (if not us).
lonix1
commented
2 months ago Murphy's Law I check some of those directories and they're empty :smile: ... I should probably use various tools for a few hours to see changes.
These seem to be zero-byte files:
clr-debug-pipe-b5187e-8d813e1c-in I assume named pipesdotnet-diagnostic-f9d9a2-e3e914e3-socket= sockets for somethingMSBuilde916f= sockets for msbuild$ tree /tmp/VS/
VS
└── AnalyzerAssemblyLoader
└── 062743844ff84b278c6a1b7b371573ab
├── 032157bc-89b1-4e73-93e3-18c0fba3f40b
│ └── xunit.analyzers.dll
├── 060ba7bc-3f62-47a5-8f4b-3a642b5b6334
│ └── Microsoft.CodeAnalysis.CodeStyle.Fixes.dll
├── 3a04c200-391f-4a6a-9d11-54c89763e567
│ └── Microsoft.CodeAnalysis.CodeStyle.dll
├── 3bf23cdb-9df7-422d-9b81-42ba61eb537b
│ └── Microsoft.CodeAnalysis.CSharp.CodeStyle.dll
├── 3c53bb73-5375-4464-aa38-c4852b5e8887
│ └── StyleCop.Analyzers.CodeFixes.dll
├── 3e67c05e-a673-4410-99a8-dee96b503071
│ └── Microsoft.CodeAnalysis.NetAnalyzers.dll
├── 4583e009-12ca-4440-b8a1-6cd53d688826
│ └── Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll
├── 4ae1e6af-ef06-4d30-bd1b-a750d9da15af
│ └── Microsoft.Interop.LibraryImportGenerator.dll
├── 4d70db62-395d-4b20-9d8b-14b6e07b2897
│ └── AsyncFixer.dll
├── 4f12f1d3-92e5-4b0d-9124-ef836cbd2389
│ └── Microsoft.AspNetCore.App.Analyzers.dll
├── 5abd8b85-009b-4128-be6e-76668ad4e60a
│ └── Microsoft.AspNetCore.App.CodeFixes.dll
├── 64888b1e-8094-4cf7-ac4a-3694db9cff2b
│ └── Microsoft.EntityFrameworkCore.Analyzers.dll
├── 708d1fb6-e9a0-4803-bf65-0538c56decc4
│ └── Microsoft.CodeAnalysis.Razor.Compiler.dll
├── 82064f6b-9278-4bab-a75b-41798fb88456
│ └── Microsoft.Interop.JavaScript.JSImportGenerator.dll
├── 8c139eb1-a8e5-434e-bd11-c5f9bf624162
│ └── Lindhart.Analyser.MissingAwaitWarning.dll
├── 8fdeef92-d6ee-472b-a264-e236956e3f0f
│ └── Microsoft.CodeAnalysis.BannedApiAnalyzers.dll
├── 93c392bd-329d-49d9-975e-7736f909a61d
│ └── System.Text.RegularExpressions.Generator.dll
├── 96520969-f53e-4ec2-abee-d215892ddf56
│ └── NSubstitute.Analyzers.Shared.dll
├── b16d67c9-b8f7-44f1-a679-211dacfee914
│ └── System.Text.Json.SourceGeneration.dll
├── b1c0ba86-da49-4b27-9c94-5c55bc6d4787
│ └── Microsoft.AspNetCore.Analyzers.dll
├── b2c91589-0af9-4a97-ad8e-dee05d734783
│ └── NSubstitute.Analyzers.CSharp.dll
├── b597c20c-1796-48ff-9e5b-fdb713983a15
│ └── StyleCop.Analyzers.dll
├── c39ef408-839c-4af9-9a74-852e6094b653
│ └── Microsoft.Extensions.Logging.Generators.dll
├── c3b7ab10-80ec-4e4d-97ac-52879f4bbceb
│ └── Microsoft.AspNetCore.Mvc.Analyzers.dll
├── c772f166-cce3-46b3-a396-9e180f98ed4a
│ └── IDisposableAnalyzers.dll
├── d1a06d15-624f-4344-95d3-525ea286bef3
│ └── Microsoft.AspNetCore.Components.Analyzers.dll
├── d27ab32d-9ab6-4d36-871f-81a4635a4db1
│ └── Microsoft.CodeAnalysis.CSharp.CodeStyle.Fixes.dll
├── d2fc6e9d-565a-43fa-934d-5f0bbc75750c
│ └── Microsoft.Extensions.Logging.Generators.dll
├── e5632702-192c-43a7-ad8e-5453caa75b08
│ └── Microsoft.Interop.SourceGeneration.dll
├── ecc0fd13-0748-46a0-8605-15ce054846e1
│ └── SerilogAnalyzer.dll
├── f9fe9f28-376f-4a3f-968b-7a24ef465f83
│ └── ToStringWithoutOverrideAnalyzer.dll
└── fe834abc-d13c-4aba-ad8e-a8f06f15e6d2
└── Microsoft.CodeAnalysis.CSharp.BannedApiAnalyzers.dllI hope if others see this issue they help by showing what sort of stuff exists in their /tmp/. This is probably the result of many dotnet-related tools, so might take a while to track down everything.
Thanks for being receptive to the issue.
CyrusNajmabadi
commented
2 months ago AnalyzerAssemblyLoader is us (roslyn). It could be the compiler, but it's also possible it's the IDE code. Tagging @jaredpar and @dibarbet .
The rest do seem to be Dotnet/MSbuild. However, it's possible it's still us wrt to calling into them and not giving them a good /tmp location (i genuinely don't know). Jared is likely a good starting point here given that vbcscompiler is def us.
jaredpar
commented
2 months ago AnalyzerAssemblyLoader is us (roslyn). It could be the compiler, but it's also possible it's the IDE code.
This is for Linux correct? If so this is very likely DevKit as the compiler doesn't use /tmp/ anymore. Our Linux strategy is to do stream based loading vs. shadow copying. The IDE should definitely be using that route as it's a much simpler story.
@dibarbet sync up with me and I'll help you get this sorted. Should be a very straight forward change.
dibarbet
commented
1 month ago Resolving this issue - https://github.com/dotnet/roslyn/pull/73809 removes the cases where we were shadow copying analyzers to /tmp on linux. This will be in an upcoming prerelease of the C# extension (most likely released next Tuesday).
The others aren't controlled directly by us and mostly look like named pipes as you mention. For MSBuildTempa or NuGetScratcha you'll likely need to followup with those teams
lonix1
commented
1 month ago Thanks I'll follow up with other teams as you proposed.
But does someone know who is responsible for those named pipes?
I didn't know which repo to use; I hope this is the right one.
I'm using VSCode on linux, where the
/tmp/directory is for ephemeral stuff; I assume it's the same for mac. Nonetheless, it is customary for programmes to place files in there in an orderly manner..NET however places dozens, sometimes hundreds, of directories in there:
And that's just a small sample. Of each category there are maybe hundreds of entries.
It's sort of "filesystem pollution", and makes it hard to use
/tmp/. I've become used to it over the years, but we should probably find a better way. It affects our interaction with all other programmes which use/tmp/as well as our own stuff because we also use/tmp/.It would be better to do as other programmes do: create a
/tmp/microsoft/directory and place everything in there.(If this is due to multiple .NET tools, please let me know which, so I can copy this issue to those repos too? Thanks.)