search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.72k stars 3.99k forks source link

Building Roslyn.sln does not deploy servicehub binaries properly., #74155

Open CyrusNajmabadi opened 2 weeks ago

CyrusNajmabadi commented 2 weeks ago

Using:

image

Repro steps.

  1. Delete RoslynDev hive
  2. Build Roslyn.sln.
  3. Make change in some code that should run in servicehub
  4. Build Roslyn.sln again

First time succeeds with:

WARNING: Potential build performance issue in 'IntegrationTestBuildProject.csproj'. The project does not appear up-to-date after a successful build: Output 'D:\github\roslyn\artifacts\bin\IntegrationTestBuildProject\Debug\net45\IntegrationTestBuildProject.dll' does not exist, not up-to-date. See https://aka.ms/incremental-build-failure.
========== Rebuild All: 207 succeeded, 0 failed, 0 skipped ==========
========== Rebuild completed at 2:10 PM and took 03:20.100 minutes ==========

Second time does not update hte hive. Attempting to run the code will result in old code loading. The only recourse is to delete the hive and do a full rebuild.

arkalyanms commented 1 week ago

@jjonescz is this different from the one you are working Rainier with a draft PR?

jjonescz commented 1 week ago

Looks like a different issue - IIUC the second build here succeeds, just doesn't update the hive. (In the previous issue, the second build failed.)

arkalyanms commented 4 days ago

Gen understands the ServiceHub deploy originally and at this point Cyrus knows the ServiceHub. Please work with Tina's team to move this bug if this cannot be fixed on our side.