search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.86k stars 4.01k forks source link

Rename session randomly dismisses itself #74347

Closed Peter-Juhasz closed 1 day ago

Peter-Juhasz commented 1 month ago

Version Used: VS 17.11.0 P3

The issue first appeared either in this or the most recent previous preview release.

Steps to Reproduce: Start a rename session and start typing new name.

It happens randomly, sometimes multiple times in a row, sometimes rarely.

See the second try:

https://github.com/dotnet/roslyn/assets/9047283/56430a59-3ec3-45c6-8b6e-300771cba39f

(I have GitHub Copilot enabled as well, perhaps it is related to the newly introduced rename suggestions?)

Diagnostic Id: N/A

Expected Behavior: The rename session stays active while I type the new name and commit it.

Actual Behavior: The rename session dismisses itself after typing the first character (or by itself?, I'm not sure what is the trigger).

CyrusNajmabadi commented 1 month ago

I'm also reproing this. Was doing a bunch of renames yesterday and about one in five would just randomly dismiss.

Cosifne commented 1 day ago

I merged a potential fix to this problem, so I am going to close this issue. If anyone see this repro feel free to open it.