search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.85k stars 4.01k forks source link

[Stabilization] BasicEditAndContinue.Locals window updates after local gets its type updated during EnC (from (empty)) #9800

Open davkean opened 8 years ago

davkean commented 8 years ago

http://dotnet-ci.cloudapp.net/job/roslyn-internal_future-stabilization_win_vsi_p0/lastCompletedBuild/testReport/(root)/BasicEditAndContinue/Locals_window_updates_after_local_gets_its_type_updated_during_EnC/

MESSAGE: Type was never loaded: Microsoft.CodeAnalysis.EditAndContinue.EditSession +++++++++++++++++++ STACK TRACE: Server stack trace: at Roslyn.Hosting.Test.VerifyInstanceCountAction.CheckType(IEnumerable1 groups, KnownType typeName, Int32 count, ComparisonKind comparison, Lazy1 types) in d:\j\workspace\roslyn-intern---75699f5a\Closed\Hosting\RoslynTaoActions\Actions\SharedActions\VerifyInstanceCountAction.cs:line 97 at Roslyn.Hosting.Test.VerifyInstanceCountAction.Execute() in d:\j\workspace\roslyn-intern---75699f5a\Closed\Hosting\RoslynTaoActions\Actions\SharedActions\VerifyInstanceCountAction.cs:line 66 at Roslyn.Hosting.Test.SerializedData.ExecuteShim() in d:\j\workspace\roslyn-intern---75699f5a\Closed\Hosting\RoslynTaoActions\Actions\SharedActions\SerializedData.cs:line 25 at Roslyn.VSHosting.Test.InProcessAPI.InvokeInVS(Action action) in d:\j\workspace\roslyn-intern---75699f5a\Closed\Hosting\Test\Actions\VisualStudio\Utilities\InProcessAPI.cs:line 51 at System.Runtime.Remoting.Messaging.StackBuilderSink._PrivateProcessMessage(IntPtr md, Object[] args, Object server, Object[]& outArgs) at System.Runtime.Remoting.Messaging.StackBuilderSink.SyncProcessMessage(IMessage msg) Exception rethrown at [0]: at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg) at System.Runtime.Remoting.Proxies.RealProxy.PrivateInvoke(MessageData& msgData, Int32 type) at Roslyn.VSHosting.Test.InProcessAPI.InvokeInVS(Action action) at Roslyn.Hosting.Test.SharedAction.Execute(TaoEngine engine) in d:\j\workspace\roslyn-intern---75699f5a\Closed\Hosting\RoslynTaoActions\Actions\SharedActions\SharedAction.cs:line 14 at Tao.Engine.DebuggableActionExecutor.Execute() in f:\dd\src\Omni\Tao\Tao.Engine\ActionExecutor.cs:line 139 at Tao.Engine.DefaultActionExecutor.Execute() in f:\dd\src\Omni\Tao\Tao.Engine\ActionExecutor.cs:line 36

Bounty

drognanar commented 8 years ago

I did not find this issue happening again on Jenkins nor on my local machine. The test logs show that EnC worked, the occurence of EditSession was 0 (so nothing was actually leaked) but the type was no longer present in the CLR Runtime after the run completed.

ManishJayaswal commented 8 years ago

@drognanar please close this if this is no longer an issue based on recent test runs.