dotnet / roslynator

Roslynator is a set of code analysis tools for C#, powered by Roslyn.
https://josefpihrt.github.io/docs/roslynator
Other
3.1k stars 261 forks source link

Method signature refactoring suggestion. #147

Open vrishe opened 7 years ago

vrishe commented 7 years ago

Greetings!

Here is an idea to make a handy method signature refactoring, so to introduce new method parameters. It may be suggested when user places cursor somewhere between existing arguments, or in close proximity to the parentheses, so to place a new parameter in that place. One has to anticipate such situations, like overridden methods update (probably with an additional warning, that may prevent accidental base class virtual methods refactoring), also there is an automatic placeholders population that will fill the default values at the changed method's call sites.

I haven't found any community-driven tools that offer such a functionality, which feels like a great omission. Also, will be happy to help out with this feature implementation if it makes sense for you, guys.

Regards,

josefpihrt commented 6 years ago

Hi,

Sorry for late answer.

I think that this would be very useful refactoring but it would be very tricky to implement.

It would require to specify a type of a new parameter and modifiers (if any). So it would mean to introduce new dialog (form).

And that leads to the idea that this feature should be implemented by Microsoft as a part of "Change signature..." dialog.