search

dotnet / roslynator

Roslynator is a set of code analysis tools for C#, powered by Roslyn.
https://josefpihrt.github.io/docs/roslynator
Other
3.07k stars 256 forks source link

Not ignoring DataSet designers. #78

Closed TrickUK closed 7 years ago

TrickUK commented 7 years ago

Having updated recently, it would seem that Roslynator isn't ignoring DataSet designer files anymore.

The classes aren't marked with any attributes, but the filenames are all .Desginer.cs so should be ignored anyway?

Regards, Richard.

josefpihrt commented 7 years ago

Hi,

I did quick test with "*.Designer.cs" file using latest version (1.3.0) and the file is excluded as expected.

Could you tell me which version are you using and which analyzer is triggered?

Thanks.

TrickUK commented 7 years ago

1.3 as of this morning, was also doing it with the previous release (not the one before that though!) devenv_2017-04-03_10-22-52

TrickUK commented 7 years ago

Just noticed it's doing it for Web references too.

josefpihrt commented 7 years ago

Which product are you using (there are 4 extensions and 2 nuget packages)?

TrickUK commented 7 years ago

Oops sorry, Roslynator for VS2015 (refactoring + analysers) installed as an extension. devenv_2017-04-03_11-01-44

josefpihrt commented 7 years ago

I found it, it's a bug.

Could you confirm that only RCS1033 and RCS1049 are fired in your generated files?

TrickUK commented 7 years ago

Yep I believe that is the case. Curiously enough I thought I'd create a testbed app so I could send an example of it happening with my ruleset etc. When I added the DataSet and a TableAdapter, the designer files aren't actually included in the solution tree (but are on disk). No analysis errors.

Looked at my project exhibiting the problem and there is no way (via IDE) to exclude the designer/xss/xsc files. Can't say I'd ever noticed they were there when they don't need to be before now!

josefpihrt commented 7 years ago

Fixed with a1241d8a27845baeb90b020cb2ab6cd8a519bed0

TrickUK commented 7 years ago

Good stuff, thanks :-)

josefpihrt commented 7 years ago

@TrickUK It's been released.

TrickUK commented 7 years ago

Awesome, now updated and a clear issue list :-)

Many thanks, better service than most commercial applications!

josefpihrt commented 7 years ago

I'm glad to hear that!