Closed AustinWise closed 6 months ago
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries See info in area-owners.md if you want to be subscribed.
I can reproduce. I have a branch that fixes enough of the C4242 warnings to pass through this. Generally the work is tracked in #99471.
Description
Compiling with the
-msbuild
flag fails with many C4242 errors in libunwind.Reproduction Steps
On commit 4e0d5d4bb45ecd9a74f651a0682b8d5371c9695b
Expected behavior
Compiles successfully. Note that that compiling with Ninja works fine:
Actual behavior
Many errors like this:
Regression?
Presumably this has something to do with #99470.
Known Workarounds
No response
Configuration
Other information
It looks like the intention was to not enable this warning for libunwind:
https://github.com/dotnet/runtime/blob/6c685e3302ebdc2aeb008a40ff475d3d3b9f2a78/src/native/external/libunwind_extras/CMakeLists.txt#L143
One thing I notice is that
eng\native\configurecompiler.cmake
turns this warning on guarded byif (MSVC)
whilesrc/native/external/libunwind_extras/CMakeLists.txt
tries to turn this off guarded byif(CLR_CMAKE_HOST_WIN32)
. I'm not enough of an expert on CMake to know if this is a problem or not.