search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.18k stars 4.72k forks source link

Issues with HW Intrinsics test templates #10097

Open CarolEidt opened 6 years ago

CarolEidt commented 6 years ago

The test templates currently produce misleading output when a test fails. The ValidateResult method sets the Succeeded field to false when it encounters an error, and all subsequent calls to ValidateResult will report failure. ValidateResult should use a local success flag to check the results, and then check that before reporting failure and setting the Succeeded field to false. I encountered this when tracking down dotnet/runtime#10079, with the SimpleTernOpTest template, but I believe it applies to the others as well.

category:testing theme:hardware-intrinsics skill-level:beginner cost:small

CarolEidt commented 6 years ago

@tannergooding @fiigii - this isn't critical but it would make tracking down failures a bit easier if this were addressed.

4creators commented 6 years ago

@CarolEidt It applies to all template based tests as they rely on single, common Succeeded bool field