Open CarolEidt opened 6 years ago
@tannergooding @fiigii - this isn't critical but it would make tracking down failures a bit easier if this were addressed.
@CarolEidt It applies to all template based tests as they rely on single, common Succeeded bool field
The test templates currently produce misleading output when a test fails. The
ValidateResult
method sets theSucceeded
field tofalse
when it encounters an error, and all subsequent calls toValidateResult
will report failure.ValidateResult
should use a local success flag to check the results, and then check that before reporting failure and setting theSucceeded
field tofalse
. I encountered this when tracking down dotnet/runtime#10079, with the SimpleTernOpTest template, but I believe it applies to the others as well.category:testing theme:hardware-intrinsics skill-level:beginner cost:small