search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.06k stars 4.69k forks source link

Double check failing `allocPgoInstrumentationBySchema` EE calls #101711

Closed jakobbotsch closed 1 month ago

jakobbotsch commented 5 months ago

101685 revealed that the EE is returning E_NOTIMPL from this function in some cases on macOS. We should double check why this happens.

The compilations where we see this in libraries_tests.run.osx.arm64.Release:

   1: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterList1:Write1_ArrayOfString(System.Object):this [Instrumented Tier0, IL size=146, code size=496, hash=0xbc1ccf13]
   2: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterList1:Write4_ArrayOfBridgeGameHighScore(System.Object):this [Instrumented Tier0, IL size=148, code size=504, hash=0xe7077814]
   3: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterSimpleTypeArray:Write3_ArrayOfSimpleType(System.Object):this [Instrumented Tier0, IL size=141, code size=484, hash=0x280d230e]
   4: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write1_wrapper(System.Object[]):this [Instrumented Tier0, IL size=219, code size=864, hash=0x271bbc41]
   5: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write3_wrapper(System.Object[]):this [Instrumented Tier0, IL size=343, code size=1080, hash=0x525b6243]
   6: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterSimpleCDC:Write1_ArrayOfString(System.Object):this [Instrumented Tier0, IL size=161, code size=536, hash=0xca4d3c2a]
   7: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterMyEnumerable1:Write1_ArrayOfString(System.Object):this [Instrumented Tier0, IL size=161, code size=536, hash=0x00d495eb]
   8: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write1_wrapper(System.Object[]):this [Instrumented Tier0, IL size=113, code size=456, hash=0x271bbc41]
   9: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterImmutableArray1:Write1_ArrayOfInt(System.Object):this [Instrumented Tier0, IL size=128, code size=460, hash=0xb2f5504c]
  10: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterImmutableArray1:Write2_ArrayOfAnyType(System.Object):this [Instrumented Tier0, IL size=125, code size=460, hash=0x86789d92]
  11: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterImmutableList1:Write1_ArrayOfInt(System.Object):this [Instrumented Tier0, IL size=151, code size=516, hash=0x188b7437]
  12: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterMyEnumerable:Write2_ArrayOfAnyType(System.Object):this [Instrumented Tier0, IL size=158, code size=516, hash=0x87ac8d82]
  13: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write2_wrapper(System.Object[]):this [Instrumented Tier0, IL size=396, code size=1292, hash=0xc17fa042]
  14: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write1_wrapper(System.Object[]):this [Instrumented Tier0, IL size=134, code size=544, hash=0x271bbc41]
  15: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriter1:Write1_wrapper(System.Object[]):this [Instrumented Tier0, IL size=115, code size=472, hash=0x271bbc41]
  16: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterSimpleTypeArray:Write3_ArrayOfSimpleType(System.Object):this [Instrumented Tier0, IL size=141, code size=484, hash=0x280d230e]
  17: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterMyList:Write2_ArrayOfAnyType(System.Object):this [Instrumented Tier0, IL size=148, code size=504, hash=0x9f590a2e]
  18: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterInt32Array:Write1_ArrayOfArrayOfInt(System.Object):this [Instrumented Tier0, IL size=225, code size=764, hash=0x5d14c9bd]
  19: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterObjectArray:Write2_ArrayOfAnyType(System.Object):this [Instrumented Tier0, IL size=141, code size=484, hash=0x82bd33b4]
  20: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterInt32Array:Write1_ArrayOfArrayOfArrayOfInt(System.Object):this [Instrumented Tier0, IL size=310, code size=1016, hash=0x5d00456d]
  21: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterList1:Write1_Places(System.Object):this [Instrumented Tier0, IL size=146, code size=496, hash=0x45ffd37e]
  22: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterList1:Write3_ArrayOfLevelData(System.Object):this [Instrumented Tier0, IL size=148, code size=504, hash=0xd1950bc2]
  23: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterMyCollection:Write2_ArrayOfAnyType(System.Object):this [Instrumented Tier0, IL size=148, code size=500, hash=0xa5ca65ba]
  24: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterEnumerableCollection:Write1_ArrayOfDateTime(System.Object):this [Instrumented Tier0, IL size=171, code size=564, hash=0x09c6d2ec]
  25: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterSimpleType:Write3_SimpleType(System.Object):this [Instrumented Tier0, IL size=65, code size=220, hash=0x63d30d07]
  26: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterList1:Write1_ArrayOfString(System.Object):this [Instrumented Tier0, IL size=146, code size=496, hash=0xbc1ccf13]
  27: JIT compiled Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationWriterXmlSchema:Write64_schema(System.Object):this [Instrumented Tier0, IL size=65, code size=220, hash=0xa653c66f]
dotnet-policy-service[bot] commented 5 months ago

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.

kunalspathak commented 3 months ago

@jakobbotsch - do you think you can take this one?

jakobbotsch commented 1 month ago

These failures aren't present anymore.