search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
14.39k stars 4.5k forks source link

[wasm] Make debug logs with string literals that create garbage conditional #101986

Closed kg closed 3 weeks ago

kg commented 1 month ago

Some of these are in hot functions and don't do anything useful. Startup measurement loops tend to block on GC quite a bit, so every little bit helps

dotnet-policy-service[bot] commented 1 month ago

Tagging subscribers to 'arch-wasm': @lewing See info in area-owners.md if you want to be subscribed.

maraf commented 1 month ago

Should we covert mono_log_debug to the same build time rewrite as mono_assert https://github.com/dotnet/runtime/blob/main/src/mono/browser/runtime/rollup.config.js#L49 ?

pavelsavara commented 3 weeks ago

Should we covert mono_log_debug to the same build time rewrite as mono_assert https://github.com/dotnet/runtime/blob/main/src/mono/browser/runtime/rollup.config.js#L49 ?

Draft of this here https://github.com/dotnet/runtime/pull/102184