search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.06k stars 4.69k forks source link

Arm/test: Update Helpers.tt and regenerate Helpers.cs #102510

Open kunalspathak opened 4 months ago

kunalspathak commented 4 months ago

It seems we are lately updating Helpers.cs file directly instead of updating Helpers.tt and generating the file from Helpers.tt .

https://github.com/dotnet/runtime/commits/main/src/tests/JIT/HardwareIntrinsics/Arm/Shared/Helpers.tt https://github.com/dotnet/runtime/commits/main/src/tests/JIT/HardwareIntrinsics/Arm/Shared/Helpers.cs

kunalspathak commented 4 months ago

@dotnet/arm64-contrib

dotnet-policy-service[bot] commented 4 months ago

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.

kunalspathak commented 2 months ago

@TIHan - can you please take care of this?

TIHan commented 2 months ago

Should I copy the code we put in Helpers.cs manually and move it to Helpers.tt?

kunalspathak commented 2 months ago

yes. The Helpers.tt code needs to be generics I believe and the tool takes care of generating the methods with generic parameters initialized.

TIHan commented 2 months ago

I'm not going to re-write the already generic code to a templatized version of it, it's not necessary. But, I'm happy to at least copy the code over to it.

a74nh commented 2 months ago

priority:3 for RC1 snap : This is a maintainability issue. Will not break anything.