dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.07k stars 4.69k forks source link

Q: System.Diagnostics.Activity out of proc monitoring value conversion culture variance #102896

Open CodeBlanch opened 4 months ago

CodeBlanch commented 4 months ago

We can use DiagnosticSourceEventSource to listen to Activity \ traces out of proc. One of the things it does is normalize all tags (KeyValuePair<string, object?>) into strings (KeyValuePair<string, string?>).

Code: https://github.com/dotnet/runtime/blob/aedb91f487e4bb4ee6f08cd3826233d434736cf7/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs#L1207

Question: Should we use InvariantCulture when we do this?

Probably also the same question\issue for metrics and logs.

/cc @tarekgh @noahfalk @samsp-msft

dotnet-policy-service[bot] commented 4 months ago

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti See info in area-owners.md if you want to be subscribed.

dotnet-policy-service[bot] commented 4 months ago

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity See info in area-owners.md if you want to be subscribed.