[API Proposal]: [QUIC] Make CompleteWritesAsync

[ManickaP]

Background and motivation

System.Net.Quic is still in Preview, before we un-preview it, we'd like to change this method to an async one. https://learn.microsoft.com/en-us/dotnet/api/system.net.quic.quicstream.completewrites?view=net-8.0

API Proposal

namespace System.Net.Quic;

// Existing class.
public class QuicStream : Stream
{
-    void CompleteWrites();
+    ValueTask CompleteWritesAsync();
}

API Usage

await using var quicStream = await connection.OpenStreamAsync(...);
// Use the stream...
await quicStream.CompleteWritesAsync();

Alternative Designs

Keeping it not-async and use existing Task WritesClosed property.

Risks

No response

[dotnet-policy-service[bot]]

Tagging subscribers to this area: @dotnet/ncl See info in area-owners.md if you want to be subscribed.

[MihaZupan]

Alternative 2: Delete the method? 😆

[bartonjs]

Video

• There were questions as to why the WritesClosed property needs to still exist, but there is a legitimate scenario.

namespace System.Net.Quic;

// Existing class.
public class QuicStream : Stream
{
-    public void CompleteWrites();
+    public ValueTask CompleteWritesAsync();
}