search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.06k stars 4.69k forks source link

runtime.proj invocation and non-deterministic restore #104077

Open am11 opened 3 months ago

am11 commented 3 months ago

https://github.com/dotnet/runtime/pull/104070#issue-2377283080 The cdac project is built via <MSBuild runtime.proj> invocation, which is where the race might be coming from (parallel tasks evaluation).

cc @ViktorHofer, @akoeplinger if the binlog screenshots from @MichalStrehovsky's investigation ring any bells https://github.com/dotnet/runtime/pull/104070#issue-2377283080

We are reverting it in the meanwhile https://github.com/dotnet/runtime/pull/104072, but would be good to understand why it fails to restore the package properly intermittently.

dotnet-policy-service[bot] commented 3 months ago

Tagging subscribers to this area: @hoyosjs See info in area-owners.md if you want to be subscribed.

ViktorHofer commented 3 months ago

I took a look and nothing stood out to me. It's really hard to say without the static graph restore binlog which unfortunately isn't available.