search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
14.97k stars 4.66k forks source link

classloader/StaticVirtualMethods/GenericContext/GenericContextTest takes very long under GC stress, times out on OSX-arm64 #104633

Open VSadov opened 2 months ago

VSadov commented 2 months ago

Examples of timeout failures:

https://[helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-103076-merge-7269229228744033b5/Loader.2.3/1/console.f932d39f.log?helixlogtype=result](https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-103076-merge-7269229228744033b5/Loader.2.3/1/console.f932d39f.log?helixlogtype=result)

https://[helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-85694-merge-c093b64e9e7a4971aa/Loader.1.3/1/console.60c249dc.log?helixlogtype=result](https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-85694-merge-c093b64e9e7a4971aa/Loader.1.3/1/console.60c249dc.log?helixlogtype=result)

https://[helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-85694-merge-c093b64e9e7a4971aa/Loader.2.3/1/console.a7c2f169.log?helixlogtype=result](https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-85694-merge-c093b64e9e7a4971aa/Loader.2.3/1/console.a7c2f169.log?helixlogtype=result)

Since this is always on a different scenario, I think it is just the test takes too long on OSX-arm64 machines. Possibly the machines are too slow and the test is too big.
(the test was mentioned before as very large and causing trouble due to size in other contexts - https://github.com/dotnet/runtime/issues/92722)

If there is no something that is particularly interesting from GC stress perspective for this test, perhaps we should just do <GCStressIncompatible>true</GCStressIncompatible>

VSadov commented 1 month ago

This is blocking clean gcstress runs. I think this should be fixed in 9.0

VSadov commented 1 month ago

Should be fixed by https://github.com/dotnet/runtime/pull/104686

VSadov commented 1 month ago

Sadly, the test seems to keep running, taking 4+ hours on osx-arm64, and failing in every runtime-coreclr gcstress0x3-gcstress0xc run.

https://dev.azure.com/dnceng-public/public/_build?definitionId=112&_a=summary