dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
14.91k stars 4.63k forks source link

Arm64/Sve: Missing test coverage for invalid immediate #104809

Closed kunalspathak closed 4 weeks ago

kunalspathak commented 1 month ago

All the test templates that verify the invalid immediate, is missing this piece of code. Thanks @amanasifkhalid for bringing this to my attention in https://github.com/dotnet/runtime/pull/104697#discussion_r1674672686.

if (!succeeded)
{
    Succeeded = false;
}

There are also certain templates like _SveImmBinaryOpTestTemplate.template that doesn't even have this test method.

kunalspathak commented 1 month ago

Assigning to @TIHan for now and we will re-distribute it if needed.

kunalspathak commented 1 month ago

@dotnet/arm64-contrib

dotnet-policy-service[bot] commented 1 month ago

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.

a74nh commented 1 month ago

priority:2 for RC1 snap : Missing testing

a74nh commented 1 month ago

Assign to myself because Mikhail is working on it.