Order of attributes matters to the platform analyzer?

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.

https://docs.microsoft.com/dotnet/core/

MIT License

14.91k stars 4.64k forks source link

Order of attributes matters to the platform analyzer? #105423

Open ericstj opened 1 month ago

ericstj commented 1 month ago

In https://github.com/dotnet/runtime/pull/105409 @akoeplinger needed to reorder platform attributes to fix an issue. I'm surprised our analyzer depends on the ordering of attributes. It's not a common characteristic of our API for order of attributes to matter. Is this intentional @buyaa-n @jeffhandley?

Reference: https://github.com/dotnet/roslyn-analyzers/pull/5266

dotnet-policy-service[bot] commented 1 month ago

Tagging subscribers to this area: @dotnet/area-system-runtime See info in area-owners.md if you want to be subscribed.

buyaa-n commented 1 month ago

In general order doesn't matter, it probably because of related platforms handling, as there is workaround @akoeplinger I assume this is not required for 9.0

akoeplinger commented 1 month ago

correct, this is not needed for 9