Closed ViktorHofer closed 2 months ago
Tagging subscribers to 'arch-wasm': @lewing See info in area-owners.md if you want to be subscribed.
That assembly only makes sense for Browser target.
It also has <TargetFrameworks>$(NetCoreAppCurrent)-browser</TargetFrameworks>
only.
Is that not enough ?
We could make all <Compile
conditional for browser only, if that helps. Essentially making that assembly empty on other platforms.
src\libraries\System.Runtime.InteropServices.JavaScript\tests\JavaScriptLibrary\JavaScriptLibrary.csproj
will probably have the same issue
That assembly only makes sense for Browser target.
For execution, yes but managed libraries must be buildable on all OSs. Maybe the linker settings are wrong?
Or to rephrase, why does the linker not emit errors when building with a TargetOS=browser?
I tested locally. If I remove
<EnableAggressiveTrimming>true</EnableAggressiveTrimming>
<PublishTrimmed>true</PublishTrimmed>
it will pass just fine on non-browser. I don't know why trimming doesn't complain for browser.
@pavelsavara can you please send me a binlog when you successfully build that project on browser (offline via Teams)? I'm not sure if I can find that in a CI run somewhere. I would like to compare the linker settings on non browser vs browser.
This needs to be fixed for https://github.com/dotnet/runtime/pull/106474
@pavelsavara