search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.42k stars 4.75k forks source link

[PERF] Issues missed by auto-filer #108027

Open DrewScoggins opened 2 months ago

DrewScoggins commented 2 months ago

These issues were missed by the auto-filer during the 9.0 development cycle. Tracking them here, as well as tagging those who seem the most likely to be able to investigate the issue based on the changes in the commit range.

Top level issue Date Notes x64 CoreCLR Win x64 CoreCLR Lin x64 MonoJit Lin Arm64 CoreCLR Lin
https://github.com/dotnet/runtime/issues/97202 (PR) 26-Jan Was not auto-filed N/A
https://github.com/dotnet/runtime/compare/f36aa7ec736735a3e92046c73d6e03029017b9fa...ee501fb2c6ac901b761131b8c4760f74b5c18a62
15-Mar No autofile N/A
https://github.com/dotnet/runtime/issues/100160 (PR) 26-Mar Missed by auto-filer N/A
https://github.com/dotnet/runtime/compare/6931b3b729ec050f935f958122d3cc66bb46fdcf...815650eaa0643ea769dfa46f320bf96ca73f7e59 5-Aug No autofile N/A
https://github.com/dotnet/runtime/compare/16cb41496d595e2568574cfe11c763d5e05136c9...9a3cacd9c9c1acbf3c1b84d5241be4091dab3e46 26-Jan No autofile N/A
https://github.com/dotnet/runtime/issues/97488 (PR) 29-Jan No regressions linked but seems to be likely cause of at least 1 Linux Coreclr x64 regression https://github.com/dotnet/runtime/issues/97488 (PR)
https://github.com/dotnet/runtime/compare/c7d36b48a493789c9267069645e2690e804a2067...d5026a18ea86195e0ca5ec8b21e8b8861d1c8656 28-Aug No autofile, unclear cause N/A
https://github.com/dotnet/runtime/issues/102261 (PR) 30-May No linked regressions, may be cause of at least one on x64LinCore https://github.com/dotnet/runtime/issues/102261 (PR)
https://github.com/dotnet/runtime/compare/6927fea7b4bca1dc2cea7a0afba0373c1303cedc...d7ae8c61f0937df4dcffe88ba96eae65fa523a78 13-Jun No autofile, one test x64LinCore N/A
https://github.com/dotnet/runtime/issues/99541 (PR) 12-Mar No regressions linked, but seemingly 1 x64LinCore regression missed https://github.com/dotnet/runtime/issues/99541 (Missed, Likely PR)
https://github.com/dotnet/runtime/issues/106578 (PR) 18-Aug No linked regressions and recent so unclear if potential cause https://github.com/dotnet/runtime/issues/106578 (PR)
https://github.com/dotnet/runtime/issues/98610 (PR) 19-Feb PR never linked to any regressions, though seems most likely to be cause of an Arm64 Lin CoreCLR regression https://github.com/dotnet/runtime/issues/98610 (Missed, PR)
https://github.com/dotnet/runtime/compare/e1c671760e23de03ee4be74eeb26831813488100...0fb0188a137f3d53a2ebd719d7a684327938609a 7-May N/A (1 Issue, Brotli.Compress_WithoutState: 7.85% reg)
https://github.com/dotnet/runtime/compare/9bb2b5be2ecc34b48a609b2445f9a13bb614a4a7...60be20ccdea212f1fa841f01114cc72324e7d56f 29-Nov N/A (1 Issue, Perf_Console.ResetConsole: 6.12%)
https://github.com/dotnet/runtime/compare/c422fca30d826b29aadf6a923369e1848a4aac97...8c02b081412e8a907ab8026d703acca7ec5c6f16 9-Nov N/A (1 Issue, LinqBenchmarks.Order00ManualX: 5.73%)
https://github.com/dotnet/runtime/compare/954ead3c0a37f8e8685dc11e19377caf975e9c8d...fae6720d5717297446b5f01a605260845420e622 13-Feb N/A (1 Issue, Perf_Uri.EscapeDataString: 14.2%)
https://github.com/dotnet/runtime/compare/74f7f9184a5e94fa3f8d234a8a39aabf996f168f...1bf325cac8b250efc7c1864471bd2c97ec3be437 19-Jun N/A (2 Issues, IPAdressPerformanceTests: Noisy NS)
https://github.com/dotnet/runtime/issues/100899 (PR) 11-Apr No regressions linked but likely cause of Arm64 lin Core ref handle stabalization to high bi-modal behavior https://github.com/dotnet/runtime/issues/100899 (PR)
https://github.com/dotnet/runtime/compare/ddf9fee30558be7a6c8f70d1014e6ec4ebd82796...0d641e527c2b392fe41abd66432a46c66876fc6a 26-Jan N/A (1 Issue, CtorFromCollectionNonGeneric: 47.94%+)
https://github.com/dotnet/runtime/compare/d752f9a19f...b29efed999 26-Feb No issue - Likely chrome bump (3 cases)
jeffschwMSFT commented 2 months ago

@DrewScoggins what are your thoughts on how to identify who should investigate the 20'ish issues above?

DrewScoggins commented 1 month ago

Sorry for the delay here. I was going to update the table here to make this a bit more actionable. I will go through and update the table with a link to the regressed test, as well as a best guess of the commit in the range that could be responsible. I will also tag the PR author.