[cdac] Finish unimplemented parts of GetMethodDescData

[lambdageek]

This is a summary of TODO|FIXME|NotImplementedEx in src/native/managed/cdacreader:

• In CodeVersions_1:
  • IsActiveNativeCodeVersion needs to handle the NativeCodeVersionHandle::CodeVersionNodeAddress non-null case - by reading the NativeCodeVersionNode data and checking the IsActive field
  • FindActiveNativeCodeVersion needs to handle the !IsActiveNativeCodeVersion(node) case by iterating over the versioning state nodes
  • FindActiveNativeCodeVersion needs to handle the ILCodeVersionHandle::ILCodeVersionNode non-null case by examining the explicit IL code version
• In ExecutionManager_1:
  • (big) ReadyToRunJitManager::GetMethodInfo needs to be implemented following ReadyToRunJitManager::JitCodeToMethodInfo in the C++ code.
• In RuntimeTypeSystem_1:
  • In GetAddressOfSlot handle the slotNum > mt.NumVirtuals case of non-virtual slots allocated in front of MethodTableAuxiliaryData
  • In GetLoaderModule handle type descs following TypeDesc::GetLoaderModule from the C++ code
  • In GetMethodClassificationDataType get the sizes for many non-IL method descriptors (FCall, PInvoke, EEImpl, ArrayMethod, ComInterp)
  • For GetMethodClassificationDataType verify that datadescriptor.h has definite sizes for all the MethodDesc subkinds
• In SOSDacImpl::GetMethodDescData:
  • Handle the cRevertedRejitVersions != 0 requests
  • Handle the pcNeededRevertedRejitData != null requests
  • Handle the HAVE_GCCOVER case and implement a GetGCCoverageInfo method for the NativeCode contract
  • Handle the bIsDynamic case
• In RuntimeTypeSystem_1 and MethodValidation: there are many // TODO(cdac): _ASSERTE (...) comments that include assertions that the C++ code had in the corresponding code. Implement them as Debug.Assert() or drop them.

[dotnet-policy-service[bot]]

Tagging subscribers to this area: @tommcdon See info in area-owners.md if you want to be subscribed.