search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.25k stars 4.73k forks source link

Upgrade our macOS build machines to the latest image #109454

Open jkoritzinsky opened 15 hours ago

jkoritzinsky commented 15 hours ago

The macOS-12 image has been deprecated and will be removed in early December.

Let's move our macOS builds to use the macos-latest image.

This is the public equivalent of the 'macos-latest-internal' image we use for official builds already.

We need to backport this to enable public builds in our servicing PRs.

jkoritzinsky commented 15 hours ago

/backport to release/9.0-staging

dotnet-policy-service[bot] commented 15 hours ago

Tagging subscribers to this area: @dotnet/runtime-infrastructure See info in area-owners.md if you want to be subscribed.

jkoritzinsky commented 15 hours ago

/backport to release/8.0-staging

github-actions[bot] commented 15 hours ago

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/11633383083

github-actions[bot] commented 15 hours ago

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/11633385070

jkoritzinsky commented 15 hours ago

Apparently AzDO doesn't support all of the images specified in https://github.com/actions/runner-images/blob/main/README.md. I guess I'll move us to macOS-13 (the last tag that corresponds to an x64 image) and we'll need to go through this song-and-dance again when that pool is deprecated.

jkoritzinsky commented 15 hours ago

/backport to release/9.0-staging

jkoritzinsky commented 14 hours ago

/backport to release/8.0-staging

github-actions[bot] commented 14 hours ago

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/11633597484

github-actions[bot] commented 14 hours ago

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/11633599152

jkoritzinsky commented 10 hours ago

Looks like there's a linker issue with the Apple Cryptography code (I assume due to using a newer Xcode toolset).

@vcsjones @bartonjs can you take a look?

vcsjones commented 9 hours ago

@akoeplinger this looks related to enabling Swift linking on iOS that was done in https://github.com/dotnet/runtime/pull/104383.

/tmp/helix/working/BA9A0A0E/p/build/apple/AppleBuild.targets(301,5): error MSB4018: ld: warning: Could not find or use auto-linked library 'swiftXPC' [/private/tmp/helix/working/BA9A0A0E/w/A6B50900/e/publish/ProxyProjectForAOTOnHelix.proj]
/tmp/helix/working/BA9A0A0E/p/build/apple/AppleBuild.targets(301,5): error MSB4018: ld: warning: Could not find or use auto-linked library 'swiftObservation' [/private/tmp/helix/working/BA9A0A0E/w/A6B50900/e/publish/ProxyProjectForAOTOnHelix.proj]
/tmp/helix/working/BA9A0A0E/p/build/apple/AppleBuild.targets(301,5): error MSB4018: Undefined symbols for architecture arm64: [/private/tmp/helix/working/BA9A0A0E/w/A6B50900/e/publish/ProxyProjectForAOTOnHelix.proj]
/tmp/helix/working/BA9A0A0E/p/build/apple/AppleBuild.targets(301,5): error MSB4018:   "__swift_FORCE_LOAD_$_swiftXPC", referenced from: [/private/tmp/helix/working/BA9A0A0E/w/A6B50900/e/publish/ProxyProjectForAOTOnHelix.proj]
/tmp/helix/working/BA9A0A0E/p/build/apple/AppleBuild.targets(301,5): error MSB4018:       __swift_FORCE_LOAD_$_swiftXPC_$_pal_swiftbindings in libSystem.Security.Cryptography.Native.Apple.a(pal_swiftbindings.o) [/private/tmp/helix/working/BA9A0A0E/w/A6B50900/e/publish/ProxyProjectForAOTOnHelix.proj]

Any chance something jumps out at you as the cause of the issue?