dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.42k stars 4.76k forks source link

threads.h: Fix up grammar/spelling in vm/threads.h #109972

Closed bchavez closed 18 hours ago

bchavez commented 2 days ago

Studying some internal CLR native NT thread handling related to https://github.com/DataDog/dd-trace-dotnet/issues/6172 and came across this threads.h code comment that needed some grammar/spelling fix ups.

Thanks,
Brian

am11 commented 2 days ago

I think most, if not all, instances reported by the following query can be updated:

git grep -i insur ':!src/native/external' (i.e. search for case-insensitive 'insur' excluding everything under src/native/external directory)

bchavez commented 2 days ago

Hi @am11, thanks for the review. I tried your command and got the following error:

image

However, I took the spirit of your command and ran it through rg/ripgrep:

rg -i insur --glob !src/native/external

and was able to get this commit be959e8 to replace other code comments with insur* -> ensur*.

And also rebased with latest on main.

Hope that helps

am11 commented 2 days ago

I was on macOS zsh where single-quotes work (same as bash,powershell etc.). For command prompt, double-quotes would work git grep -i insur ":!src/native/external" (or no quotes since there is no space in that path segment)

Thanks for the update, LGTM!

dotnet-policy-service[bot] commented 2 days ago

Tagging subscribers to this area: @dotnet/area-meta See info in area-owners.md if you want to be subscribed.

jkotas commented 18 hours ago

/ba-g Know issue https://github.com/dotnet/runtime/issues/110008, Format jit codebase

jkotas commented 18 hours ago

Thank you!