Small clean up in assertionprop for relops

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.

https://docs.microsoft.com/dotnet/core/

MIT License

15.42k stars 4.76k forks source link

Small clean up in assertionprop for relops #109987

Closed EgorBo closed 20 hours ago

EgorBo commented 2 days ago

This PR: 1) Simplifies optVNConstantPropOnJTrue 2) Enables constant folding for relops with side-effects 3) optAssertionProp_RangeProperties now for array[idx] = 42; tells that array.Length is never negative and never zero.

dotnet-policy-service[bot] commented 2 days ago

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch See info in area-owners.md if you want to be subscribed.

EgorBo commented 2 days ago

PTAL @jakobbotsch @dotnet/jit-contrib PTAL, small diffs (mostly just a code cleanup)

am11 commented 21 hours ago

Ignore format jit errors. Once https://github.com/zlib-ng/zlib-ng/pull/1810 is reviewed/merged, I'll port the patch.