search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.41k stars 4.76k forks source link

Delete pragma suppression for warning disabled with UnconditionalSuppressMessage #110030

Closed MichalStrehovsky closed 18 hours ago

MichalStrehovsky commented 1 day ago

https://github.com/dotnet/runtime/pull/109963#discussion_r1850060556

dotnet-policy-service[bot] commented 1 day ago

Tagging subscribers to this area: @dotnet/ncl See info in area-owners.md if you want to be subscribed.

Youssef1313 commented 22 hours ago

@MichalStrehovsky Is this going to be backported for .NET 8 to avoid the IL3000 in apps?

MichalStrehovsky commented 22 hours ago

@MichalStrehovsky Is this going to be backported for .NET 8 to avoid the IL3000 in apps?

The thing that needs backporting is the UnconditionalSuppressMessage on line 73 (that I'm not touching here). Deleting the pragma is not necessary to service.

I believe @rzikm is on top of that.

rzikm commented 22 hours ago

Thanks, I was planning to address your comment today myself.

Servicing PR is in progress.