[mono][aot] Fix compilation crashes when type load exception is generated in code

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.

https://docs.microsoft.com/dotnet/core/

MIT License

15.42k stars 4.76k forks source link

[mono][aot] Fix compilation crashes when type load exception is generated in code #110078

Open BrzVlad opened 8 hours ago

BrzVlad commented 8 hours ago

Following https://github.com/dotnet/runtime/pull/91261, exception throwing during aot compilation for type load exceptions was replaced with throwing of exception at runtime, as part of the method code. This code insertion could hit some issues in various scenarios. Fixes https://github.com/dotnet/runtime/issues/110003 and https://github.com/dotnet/runtime/issues/109966

dotnet-policy-service[bot] commented 8 hours ago

Tagging subscribers to this area: @steveisok, @vitek-karas See info in area-owners.md if you want to be subscribed.

vitek-karas commented 5 hours ago

Sorry - no idea about the code change... but a question about the regression: I'm curious how it is that it was in 9.0 for a year and we didn't detect it? Are we missing some tests, should we add them as part of this change?