search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.26k stars 4.73k forks source link

Performance regression: EmptyAsyncMethodInvocation benchmark #13132

Closed adamsitnik closed 1 month ago

adamsitnik commented 5 years ago

Repro

git clone https://github.com/dotnet/performance.git
cd performance
# if you don't have cli installed and want python script to download the latest cli for you
py .\scripts\benchmarks_ci.py -f netcoreapp2.2 netcoreapp3.0 --filter System.Threading.Tasks.Tests.Perf_AsyncMethods.EmptyAsyncMethodInvocation
# if you do
dotnet run -p .\src\benchmarks\micro\MicroBenchmarks.csproj -c Release -f netcoreapp2.2 --runtimes netcoreapp2.2 netcoreapp3.0 --filter System.Threading.Tasks.Tests.Perf_AsyncMethods.EmptyAsyncMethodInvocation

System.Threading.Tasks.Tests.Perf_AsyncMethods.EmptyAsyncMethodInvocation

conclusion Base Diff Base/Diff Modality Operating System Arch Processor Name Base Runtime Diff Runtime
Slower 13.41 25.20 0.53 ubuntu 18.04 64bit Intel Xeon CPU E5-1650 v4 3.60GHz .NET Core 2.2.6 .NET Core 3.0.0-preview8-27919-09
Slower 11.76 13.81 0.85 Windows 10.0.18362 64bit Intel Xeon CPU E5-1650 v4 3.60GHz .NET Core 2.2.6 .NET Core 3.0.0-preview8-27919-09
Slower 21.61 27.30 0.79 ubuntu 16.04 64bit Intel Xeon CPU E5-2673 v4 2.30GHz .NET Core 2.2.6 .NET Core 3.0.0-preview8-27919-01
Slower 21.90 54.03 0.41 bimodal ubuntu 18.04 64bit Intel Xeon CPU E5-2673 v4 2.30GHz .NET Core 2.2.6 .NET Core 3.0.0-preview8-27919-01
Slower 15.15 17.61 0.86 macOS Mojave 10.14.5 64bit Intel Core i7-5557U CPU 3.10GHz (Broadwell) .NET Core 2.2.6 .NET Core 3.0.0-preview8-27919-09
Slower 12.89 16.88 0.76 Windows 10.0.18362 64bit Intel Core i7-5557U CPU 3.10GHz (Broadwell) .NET Core 2.2.6 .NET Core 3.0.0-preview8-27919-09
Slower 11.39 12.48 0.91 Windows 10.0.18362 64bit Intel Core i7-7700 CPU 3.60GHz (Kaby Lake) .NET Core 2.2.6 .NET Core 3.0.0-preview8-27919-09
Slower 13.55 15.45 0.88 Windows 10.0.18362 64bit AMD Ryzen 7 1800X .NET Core 2.2.6 .NET Core 3.0.0-preview8-27919-09
Same 17.88 18.47 0.97 Windows 10.0.18362 32bit Intel Xeon CPU E5-1650 v4 3.60GHz .NET Core 2.2.6 .NET Core 3.0.0-preview8-27919-09

/cc @danmosemsft @stephentoub @billwert @DrewScoggins

kouvel commented 5 years ago

CC @tarekgh

tarekgh commented 5 years ago

@stephentoub any idea of any change affect this case perf?

tarekgh commented 5 years ago

Moved this one to the future according the bar this test scenario is really a corner case. We still need to look at that at some point.

dotnet-policy-service[bot] commented 2 months ago

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

dotnet-policy-service[bot] commented 1 month ago

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.