Closed adamsitnik closed 2 years ago
@adamsitnik thanks for the finding, will you be following up on this issue, to assign it to you?
@safern @adamsitnik Does this need to be a 3.0 issue?
@adamsitnik System.Collections.IndexerSet.Dictionary(Size: 512)
appears twice, because of two GenericTypeArguments
. From your comments it sounds like the first one is the typeof(int)
one but I wonder whether BDN could somehow disambiguate it's output? Even if it was the index of the parameter (1, 2)
My take (I am interested in @billwert @safern @adamsitnik thoughts) is that we probably do not want to attempt to address this in 3.0 because the code here (whether in Dictionary or codegen) is subtle and easy to regress perf elsewhere. We have some great wins in many other common scenarios here and we can see whether we get feedback on this scenario.
Doesn't sound like it meets any bar for 3.0 to me. Agree we should act based on feedback.
Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.
This process is part of the experimental issue cleanup initiative we are currently trialing in a limited number of areas. Please share any feedback you might have in the linked issue.
This issue will now be closed since it had been marked no recent activity
but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.
It looks like
TryGetValueFalse
,IndexerSet
andContainsKeyFalse
benchmarks have regressed for Dictionaries of Value Types (at least for int).If you run the benchmarks from command prompt on Windows remember to escape the
<
and>
characters https://stackoverflow.com/questions/251557/escape-angle-brackets-in-a-windows-command-prompt/cc @danmosemsft @AndyAyersMS @billwert @DrewScoggins