search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.39k stars 4.75k forks source link

The test is failing on 2 platforms with this change #1913

Closed hamarb123 closed 4 years ago

hamarb123 commented 4 years ago

Please read PR #1853 and issue #1740 first, thanks.

It seems like the test is failing on 2 platforms: Windows_NT netfx x86 Release, and Windows_NT x64. I imagine the reasoning behind the netfx failure is because it must still have the old code, but can anyone tell me what the other one is, its error messages don't make sense to me. Also, what should I do to fix the netfx platform?

Originally posted by @hamarb123 in https://github.com/dotnet/runtime/pull/1853#issuecomment-575776850

https://github.com/dotnet/runtime/pull/1853/checks?check_run_id=395012296

Gnbrkm41 commented 4 years ago

The EventPipe failures appear to be the same as https://github.com/dotnet/runtime/issues/1892.

Unless the fix can be made in .NET Framework as well, I believe that you should conditionally compile with #if NETFRAMEWORK to use different test data for .NET Framework.

hamarb123 commented 4 years ago

@Gnbrkm41, do you know where the .NET Framework equivalent of this is? Is it this, should I PR there too?

Gnbrkm41 commented 4 years ago

.NET Framework sources are read-only, so it would be the folks at MS that would make the fix.

hamarb123 commented 4 years ago

@Gnbrkm41, so I should just make it conditional and then they can change it later for netfx if they want?

Gnbrkm41 commented 4 years ago

That's my understanding of it, yes.