search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.06k stars 4.69k forks source link

ManagedHandler: ManagedHandler_DefaultCredentialsTest tests are disabled #23137

Closed stephentoub closed 4 years ago

stephentoub commented 7 years ago

These tests are disabled for the managed handler. They need to be investigated and either src or tests fixed.

wfurt commented 7 years ago

This one is only for windows platforms.

Priya91 commented 7 years ago

These tests are for testing credentials with negotiate and ntlm auth. The infrasturcture to run these tests doesn't exist yet, closing this bug as dupe of dotnet/runtime#17845

davidsh commented 7 years ago

@Priya91

There is still a TODO in the source code that references this issue number.

Usually, if we want to close one issue as a dupe of the other, we need to change the issue number in the source code as well. Otherwise, we end up with orphan issue numbers in the source code.

See: https://github.com/dotnet/corefx/blob/master/src/System.Net.Http/tests/FunctionalTests/ManagedHandlerTest.cs#L125

davidsh commented 7 years ago

cc: @karelz

Priya91 commented 7 years ago

@davidsh I was just creating a PR as we speak :)

davidsh commented 7 years ago

ok. sounds good. But to avoid confusion, please close the issue after the PR? As you can see, I was confused. :)

karelz commented 7 years ago

Should we assign it to @Priya91 then? Or will it be just partial fix?