search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.15k stars 4.71k forks source link

EventSource: Improve debug message more clear #23844

Closed ibocon closed 2 hours ago

ibocon commented 7 years ago

string _EventSourceVarArgsParameterMismatch in Microsoft.Diagnostics.tracing.EventSource.Redist could be improved showing lists of mismatch type and how they are not match.

Current debug message is

parameters to the Event method do not match the parameters to the WriteEvent method. This may cause the event to be displayed incorrectly.

danmoseley commented 7 years ago

@vancem would you accept a PR for such a change...?

vancem commented 7 years ago

@vancem would you accept a PR for such a change...?

Yes I would accept this change. We actually have this information it is just a matter of localizing it so we can spit it out, and it is useful.

However it is not a high priority because typically you can figure it out pretty easily. (after all most events have < 3 parameters). If someone in the community wants to do it, that would be great.

brianrob commented 7 years ago

Also, this change should be made in the CoreCLR repo since that's where it will sync to the rest of the runtimes. Microsoft.Diagnostics.Tracing.EventSource.Redist is currently just a static copy of those two - I'm working on getting it to sync as well.

danmoseley commented 7 years ago

@brianrob you can talk to @safern if you want to reuse the git-syncing-daemon that works between corert and coreclr.

brianrob commented 7 years ago

@danmosemsft, yes! I will reach out to @safern. Thank you.

dotnet-policy-service[bot] commented 2 weeks ago

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

dotnet-policy-service[bot] commented 2 hours ago

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.