Closed JeremyKuhne closed 1 month ago
Triage: We should wait for the UTF-8 string work to finish to finalize on what we do here.
Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.
This process is part of our issue cleanup automation.
This issue will now be closed since it had been marked no-recent-activity
but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.
A UTF-8 implementation of
FileSystemName.MatchesSimpleExpression
would allow matching Unix/Mac data without having to first convert to UTF-16. Something like this perhaps:This could potentially improve performance. We currently convert from UTF-8 into a temporary UTF-16 buffer on the stack- it may also be that improvements here don't register against the cost of I/O. https://github.com/dotnet/corefx/blob/master/src/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEntry.Unix.cs#L88-L103
If anyone has a particular interest in this they are welcome to try and implement. If we find there is, in fact, a measurable benefit we can look at making a formal API proposal at that point.