dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.26k stars 4.73k forks source link

Cleanup MSDN URL's in sources #27554

Closed danmoseley closed 4 years ago

danmoseley commented 6 years ago

From grepping corefx/src/*/src/**cs, I find these non-https Microsoft links:

http://msdn.microsoft.com/en-us/library/4bw5ewxy.aspx 
http://msdn.microsoft.com/en-us/library/aa364661.aspx
http://msdn.microsoft.com/en-us/library/aa384043(VS.85).aspx.
http://msdn.microsoft.com/en-us/library/d8eyd8zc.aspx).
http://msdn.microsoft.com/en-us/library/ms131709.aspx)
http://msdn.microsoft.com/en-us/library/ms172338.aspx)
http://msdn.microsoft.com/en-us/library/ms173829.aspx
http://msdn.microsoft.com/en-us/library/ms687401.aspx]
http://msdn.microsoft.com/en-us/library/windows/desktop/aa366907(v=vs.85).aspx
http://msdn.microsoft.com/en-us/library/windows/desktop/aa382741.aspx)
http://msdn.microsoft.com/en-us/library/windows/desktop/aa382741.aspx) for details.
http://msdn.microsoft.com/en-us/library/windows/desktop/aa383153(v=vs.85).aspx
http://msdn.microsoft.com/en-us/library/x810d419.aspx
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/com/error_9td2.asp.
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/com/htm/oen_a2z_8jxi.asp.
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/cpguide/html/cpconcustomnumericformatstrings.asp</spec>
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/cpref/html/frlrfsystemglobalizationcultureinfoclassisneutralculturetopic.asp
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/base/synchronization_object_security_and_access_rights.asp
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/gdicpp/GDIPlus/GDIPlusreference/enumerations/stringformatflags.asp,
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/odbc/htm/odbcsqldriverconnect.asp
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/odbcsql/od_odbc_d_4x4k.asp
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/oledb/htm/oledbconnectionstringsyntax.asp
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/sysinfo/base/registry_key_security_and_access_rights.asp
http://msdn.microsoft.com/library/psdk/gdi/prntspol_8nle.htm),

http://go.microsoft.com/fwlink");
http://go.microsoft.com/fwlink/?linkid=14202")]
http://go.microsoft.com/fwlink/?linkid=14202", false)]
http://go.microsoft.com/fwlink/?linkid=14202", false)] // 79027
http://go.microsoft.com/fwlink/?linkid=14202=14202")]
http://go.microsoft.com/fwlink/?LinkID=155570 for more information.")]
http://go2.microsoft.com/fwlink/?LinkId=131738 for more information.")]

All of these should be updated to https as a matter of good practice. Also some are dead links that either should be fixed or removed.

Low priority cleanup

jkotas commented 6 years ago

Also, it would be nice to convert these to point to https://docs.microsoft.com/ where the most current docs live these days.

samneirinck commented 6 years ago

In the spirit of Hacktoberfest, I'll pick this up. Most of them redirect to the correct https://docs.microsoft.com url already, so I'll replace them with the up-to-date https links.

Wraith2 commented 6 years ago

I'd done a few but i'll leave them to you @samneirinck, The problems I found were that some don't exist anymore and it isn't clear what they refered to in the first place.

System.Data.Common\src\System\Data\Common\DbConnectionOptions.cs:               //     http://msdn.microsoft.com/library/default.asp?url=/library/en-us/odbcsql/od_odbc_d_4x4k.asp
System.Data.Common\src\System\Data\Common\DbConnectionOptions.cs:               //     http://msdn.microsoft.com/library/default.asp?url=/library/en-us/oledb/htm/oledbconnectionstringsyntax.asp
System.Data.Common\src\System\Data\DataTable.cs:                // http://msdn.microsoft.com/library/default.asp?url=/library/en-us/cpref/html/frlrfsystemglobalizationcultureinfoclassisneutralculturetopic.asp
System.Data.Odbc\src\Common\System\Data\Common\DbConnectionOptions.cs:          //     http://msdn.microsoft.com/library/default.asp?url=/library/en-us/odbcsql/od_odbc_d_4x4k.asp
System.Data.Odbc\src\Common\System\Data\Common\DbConnectionOptions.cs:          //     http://msdn.microsoft.com/library/default.asp?url=/library/en-us/oledb/htm/oledbconnectionstringsyntax.asp
System.Data.SqlClient\tests\StressTests\System.Data.SqlClient.Stress.Tests\NetUtils.cs:         // according to http://msdn.microsoft.com/en-us/library/ms819739.aspx and http://msdn.microsoft.com/en-us/library/ee377084(BTS.10).aspx,
System.Private.Uri\tests\FunctionalTests\IriTest.cs:        // List built based on http://msdn.microsoft.com/en-us/library/aa292086(v=vs.71).aspx
System.IO.MemoryMappedFiles\src\System\IO\MemoryMappedFiles\MemoryMappedView.Windows.cs:            // VirtualQueryEx: http://msdn.microsoft.com/en-us/library/windows/desktop/aa366907(v=vs.85).aspx

Is still correct, the docs.microsoft page redirects to it