search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.05k stars 4.69k forks source link

Renable WebSocket Client tests with ServerInitiatedClose semantics #28957

Open davidsh opened 5 years ago

davidsh commented 5 years ago

These tests were disabled when we moved the external Azure test endpoint to Azure App Service:

https://github.com/dotnet/corefx/blob/master/src/System.Net.WebSockets.Client/tests/CloseTest.cs

Azure App Service (unlike VMs or Cloud Service) uses a reverse proxy on the front-end which causes some problems with our testing of WebSocket client close scenarios with server initiated close frames.

These tests can be re-enabled once they are moved to a loopback based WebSocket server.

stephentoub commented 5 years ago

These tests were disabled

Where are they disabled? I see: https://github.com/dotnet/corefx/blob/2696d751a7b50bdc3e03bf5089f67aa0bd081b24/src/System.Net.WebSockets.Client/tests/CloseTest.cs#L20-L22 and https://github.com/dotnet/corefx/blob/2696d751a7b50bdc3e03bf5089f67aa0bd081b24/src/System.Net.WebSockets.Client/tests/CloseTest.cs#L199-L201

Did you mean they're outer loop instead of inner?

stephentoub commented 5 years ago

Oh, I see, you just put up a PR to disable them. :)