search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.47k stars 4.77k forks source link

[.Net Core][LOC]The item '(Collection)' in PropertyGrid is not translated in .Net core #29481

Open JuditRose opened 5 years ago

JuditRose commented 5 years ago

@Jessie-Zhang01 commented on Sun Apr 14 2019

OS: RS3 X64 JPN VS: Dev16 16.1 d16.1 branch 28811.12 build JPN .NET Core: 3.0.100-preview4-011198 from Release branch

More info: This issue also can reproduce with all 13 local languages: CHS, CHT, CSY, DEU, ESN, ITA, JPN, KOR, PLK, PTB, RUS, TRK, FRA

Steps to reproduce:

  1. Install the .NET Core 3.0 SDK from https://github.com/dotnet/core-sdk for Release branch
  2. Open the .NET Core app from \\mlangfs1\public\Winforms\CoreTest\LocalValidation\WindowsFormsApp4.zip in VS.
  3. Run it and observe the ‘Nodes’ component in PropertyGrid

Actual: The item '(Collection)' in PropertyGrid is not translated in .Net core. image

Expected: The item '(Collection)' in PropertyGrid should be translated in .Net core. Following is the screenshot of .Net framework, it is translated. image

@dreddy-work commented on Fri Apr 19 2019

@zsd4yr , can you please follow up on this?

@zsd4yr commented on Mon Apr 22 2019

There does not appear to be an entry for (Collection) in any resx file.

image

@JuditRose did you miss this while porting the collection editor?

@JuditRose commented on Wed May 08 2019

It looks like the translation is coming from the CollectionConverterText translation key from corefx: https://github.com/dotnet/corefx/blob/c390ce7df50252e11f5d322276e9d19e046d1332/src/System.ComponentModel.TypeConverter/src/Resources/Strings.resx#L238 @Tanya-Solyanik said that earlier there was a discussion about what to translate and what not to translate, and this was one of the areas that was agreed not to be translated. Maybe it worth to reevaluate.

maryamariyan commented 5 years ago

cc: @vivmishra

vivmishra commented 5 years ago

As this is in CoreFX, we can set the milestone to Future as CoreFX is not in scope for loc in 3.0.