Installation completed info should not be shown with Runtime installer when uninstallation is completed

NicoleWang001 commented 5 years ago

Steps to reproduce

Install .NET core runtime-3.0.0-preview6-27804-01 with runtime installer
Uninstall it
Observe Uninstall Successfully Completed page

Expected behavior

It only shows the info for uninstall successfully completed. Take .NET Core SDK installer for example

Actual behavior

Installation completed info is showing on uninstall successfully completed page

MichaelSimons commented 5 years ago

When fixing, please validate whether or not this applies to the 2.* installers as well.

NikolaMilosavljevic commented 4 years ago

@NikolaMilosavljevic please verify and close if no repro.

NikolaMilosavljevic commented 4 years ago

I will confirm that SDK is doing this right and if we can use the same model. Otherwise, will move it to 6.0.

NikolaMilosavljevic commented 4 years ago

The fix should follow SDK implementation model: https://github.com/dotnet/installer/blob/e8e3c763bfb77c90a9d985afbd73d759f03b61ca/src/redist/targets/packaging/windows/clisdk/bundle.thm#L73

Burn bootstrapper application can enable and disable, based on installation operation (install/uninstall/repair) several elements with hard-coded names. One of them is SuccessInstallHeader element on the "Success" page.

This element should be updated to Richedit type, and contain all content that is currently displayed in the following elements:

SuccessInstallLocation
SuccessInstallProductName
SuccessInstallResourcesHeader
DocumentationLink
RelaseNotesLink
TutorialLink
TelemetryLink

The following elements should be removed:

SuccessInstallProductName
SuccessInstallResourcesHeader
DocumentationLink
RelaseNotesLink
TutorialLink
TelemetryLink

dotnet / runtime