Duplicates in different config sources are treated differently

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.

https://docs.microsoft.com/dotnet/core/

MIT License

14.82k stars 4.61k forks source link

Open ajcvickers opened 5 years ago

ajcvickers commented 5 years ago

Specifically, duplicates within a given source. For example, the same setting repeated twice in an .ini file.

These providers throw either ArgumentException or FormatException:

These providers ignore duplicates if the case does match:

These providers ignore duplicates if the case does not match:

These providers ignore duplicates:

ajcvickers commented 5 years ago

See:

ajcvickers commented 5 years ago

Notes from triage:

Providers that currently ignore duplicates should continue to do so to avoid breaking existing apps
For 3.0 we would consider a change that consolidated all the exception types/messages across providers into one consistent exception and message. (This is technically also a breaking change, but one that is unlikely to cause real-world issues. Still; better to do it in 3.0 than in a non-breaking release.)

maryamariyan commented 3 years ago

This issue seems to have a dupe. I will link once I find it.