search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.27k stars 4.73k forks source link

Bundler tests should clear files extracted to tmp #39476

Open mateoatr opened 4 years ago

mateoatr commented 4 years ago

Some single-file tests require the extraction of bundled files out to disk, such files will go to the tmp dir, potentially causing the machine to run out of space if the developer runs the installer tests many times (and this can happen rather quickly; the total size of the files extracted by these tests is 582M). This doesn't cause much problem since the user can manually delete such files, although we should clear extracted files as part of the tests.

ghost commented 4 years ago

Tagging subscribers to this area: @swaroop-sridhar, @agocke Notify danmosemsft if you want to be subscribed.

agocke commented 4 years ago

Is this test-only or could this also affect customers? If you run a single-file app is it guaranteed to re-use the extraction directory that it used in its last run?

mateoatr commented 4 years ago

Is this test-only or could this also affect customers? If you run a single-file app is it guaranteed to re-use the extraction directory that it used in its last run?

This is a test-only problem. Every time the installer tests are run, a new single-file app is published (with a new bundle ID).