search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.16k stars 4.71k forks source link

Performance pipelines depends on OOBs being present in the testhost #39694

Open ViktorHofer opened 4 years ago

ViktorHofer commented 4 years ago

Current the perf pipelines depends on OOBs being present in the testhost folder instead of being acquired app-local (which represents the customer scenario). We are removing OOBs from the testhost with https://github.com/dotnet/runtime/pull/35606.

I added a workaround to manually copy the runtime directory's content which includes OOBs into the testhost. This is a hack and should be fixed i.e. by including the built packages (e.g. System.Drawing.Common) into the payload and then restoring from that cache. I don't have enough context how the perf pipeline works but I assume, as I saw that the whole dotnet/performance repository is part of the correlation payload, that the performance library isn't prebuilt.

cc @adamsitnik @DrewScoggins @safern

ghost commented 4 years ago

Tagging subscribers to this area: @safern, @tannergooding Notify danmosemsft if you want to be subscribed.

ghost commented 4 years ago

Tagging subscribers to this area: @ViktorHofer Notify danmosemsft if you want to be subscribed.