search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.47k stars 4.77k forks source link

Broken parsing of c# file (static delegate?) #39844

Closed vsfeedback closed 3 years ago

vsfeedback commented 4 years ago

This issue has been moved from a ticket on Developer Community.

[severity:My work is severely impacted or blocked (internal MSFT only)] Repro steps

1) Open dotnet runtime System.Net.Http solution: https://github.com/dotnet/runtime/tree/master/src/libraries/System.Net.Http 2) Open src\libraries\System.Net.Http\src\System\Net\Http\SocketsHttpHandler\Http2Connection.cs

Symptoms

The file failed to parse and show lot or errors. I'm able to build the solution from command line, so the file should be valid.

VS info

Microsoft Visual Studio Enterprise 2019 Preview Version 16.7.0 Preview 4.0 VisualStudio.16.Preview/16.7.0-pre.4.0+30310.162 Microsoft .NET Framework Version 4.8.04084

Installed Version: Enterprise

Visual C++ 2019 00435-60000-00000-AA488 Microsoft Visual C++ 2019

ASP.NET and Web Tools 2019 16.7.523.48425 ASP.NET and Web Tools 2019

ASP.NET Core Razor Language Services 16.1.0.2035807+72d099b977d3a85e65fa3b0614ca8cfc803fef02 Provides languages services for ASP.NET Core Razor.

ASP.NET Web Frameworks and Tools 2019 16.7.523.48425 For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0 16.7.523.48425 Azure App Service Tools v3.0.0

Azure Functions and Web Jobs Tools 16.7.523.48425 Azure Functions and Web Jobs Tools

C# Tools 3.7.0-4.20359.1+b90347a69117be7181e2f03a991790634981eddb C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools 1.10 Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Cookiecutter 16.7.20181.2 Provides tools for finding, instantiating and customizing templates in cookiecutter format.

IntelliCode Extension 1.0 IntelliCode Visual Studio Extension Detailed Info

Microsoft Azure Tools 2.9 Microsoft Azure Tools for Microsoft Visual Studio 2019 - v2.9.30701.1

Microsoft Continuous Delivery Tools for Visual Studio 0.4 Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE.

Microsoft JVM Debugger 1.0 Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft Library Manager 2.1.79+ge3567815aa.RR Install client-side libraries easily to any web project

Microsoft MI-Based Debugger 1.0 Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards 1.0 Microsoft Visual C++ Wizards

Microsoft Visual Studio Tools for Containers 1.1 Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.

Microsoft Visual Studio VC Package 1.0 Microsoft Visual Studio VC Package

NuGet Package Manager 5.7.0 NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

Productivity Power Tools 2017/2019 16.0 Installs the individual extensions of Productivity Power Tools 2017/2019

ProjectServicesPackage Extension 1.0 ProjectServicesPackage Visual Studio Extension Detailed Info

Python 16.7.20181.2 Provides IntelliSense, projects, templates, debugging, interactive windows, and other support for Python developers.

Python - Conda support 16.7.20181.2 Conda support for Python projects.

Python - Django support 16.7.20181.2 Provides templates and integration for the Django web framework.

Python - IronPython support 16.7.20181.2 Provides templates and integration for IronPython-based projects.

Python - Profiling support 16.7.20181.2 Profiling support for Python projects.

Snapshot Debugging Extension 1.0 Snapshot Debugging Visual Studio Extension Detailed Info

SQL Server Data Tools 16.0.62006.04220 Microsoft SQL Server Data Tools

Test Adapter for Boost.Test 1.0 Enables Visual Studio's testing tools with unit tests written for Boost.Test. The use terms and Third Party Notices are available in the extension installation directory.

Test Adapter for Google Test 1.0 Enables Visual Studio's testing tools with unit tests written for Google Test. The use terms and Third Party Notices are available in the extension installation directory.

TypeScript Tools 16.0.20702.2001 TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools 3.7.0-4.20359.1+b90347a69117be7181e2f03a991790634981eddb Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual C++ for Cross Platform Mobile Development (Android) 16.0.30309.115 Visual C++ for Cross Platform Mobile Development (Android)

Visual F# Tools 10.10.0.0 for F# 4.7 16.7.0-beta.20329.1+19c9e2f1b21a66ec90fefae79988b33fc16744fc Microsoft Visual F# Tools 10.10.0.0 for F# 4.7

Visual Studio Code Debug Adapter Host Package 1.0 Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Container Tools Extensions (Preview) 1.0 View, manage, and diagnose containers within Visual Studio.

Visual Studio Tools for CMake 1.0 Visual Studio Tools for CMake

Visual Studio Tools for Containers 1.0 Visual Studio Tools for Containers

Original Comments

Feedback Bot on 7/22/2020, 00:27 AM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Tarek Mahmoud Sayed [MSFT] on 7/23/2020, 09:53 AM:

We moved this issue to a relevant GitHub project. Please comment and track it at this URL: https://github.com/dotnet/runtime/issues/39843

Original Solutions

Tarek Mahmoud Sayed [MSFT] solved on 7/22/2020, 09:44 AM, 0 votes:

Thanks for reporting the issue. We couldn’t report the issue but this may happen if there are some packages not stored when you loaded the solution. Could you please try to build the repo once and then reopen the solution and look if you still seeing this issue? Thanks.

mapichov [MSFT] on 7/23/2020, 08:32 AM:

I'm hitting the same issue, updated VS preview, freshly build repo.

Tarek Mahmoud Sayed [MSFT] on 7/23/2020, 09:33 AM:

did you try to build the repo before loading the solution? and if you compile the solution do you see errors? or it is just the editor showing this issue?

Dotnet-GitSync-Bot commented 4 years ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ghost commented 4 years ago

Tagging subscribers to this area: @dotnet/ncl See info in area-owners.md if you want to be subscribed.

scalablecory commented 4 years ago

This is a Visual Studio bug, not a .NET bug. @tarekgh can you reroute the original bug to VS?

tarekgh commented 4 years ago

@scalablecory can't this be because of our toolchain customization? remember we build in Runtime so different than regular projects. This could be the NuGet packages not restored properly when loading the project which can cause this issue. I would recommend someone need to look at this first before we send it to VS.

scalablecory commented 4 years ago

Ahhh I see, ok. @safern can you please help us out here?

FWIW I can not reproduce this on my machine.

tarekgh commented 4 years ago

FWIW I can not reproduce this on my machine.

This may depend on if you built the repo before (I didn't try that though). you may try do git clean -fdx and then go and load the solution after that.

aik-jahoda commented 4 years ago

I reproduced it again with latest VS (16.7.0 Preview 6.0) + latest master:

  1. Sync local master with the latest runtime master

  2. git clean -fdx
.\build.cmd libs+clr -c debug -rc release

  3. Open \src\libraries\System.Net.Http\System.Net.Http.sln in the Visual Studio. In the output window I can see the following, not sure if it is related:

    
Time Elapsed: 00:00:00.0505126
========== Finished ==========

Error occurred while restoring NuGet packages: Invalid restore input. Duplicate frameworks found: 'net5.0, net5.0, net5.0, net5.0, net5.0, net5.0, net5.0'. Input files: C:\Users\jajahoda\workspace\runtime\src\libraries\System.Net.Http\src\System.Net.Http.csproj.


4. Open `\src\libraries\System.Net.Http\src\System\Net\Http\SocketsHttpHandler\Http2Connection.cs` in the Visual Studio.
The file is broken from the following line: https://github.com/dotnet/runtime/blob/215db60d405f6a963121b54035a35163681ff5b7/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs#L910

@ManickaP, as you experienced the same issue with the Visual Studio, can you check the error from point number 3? Is it same on your machine?
safern commented 4 years ago

@aik-jahoda number 3 is a known issue https://github.com/dotnet/runtime/issues/32205

For number 4 I have tried to repro but wasn't able. I'm trying to upgrade my VS to latest preview now.

geoffkizer commented 3 years ago

Closing. Please reactivate if there is still some issue here.