dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.03k stars 4.67k forks source link

Write guidance about checking in test data in test projects vs dotnet/runtime-assets #42428

Open layomia opened 4 years ago

layomia commented 4 years ago

From @danmosemsft in https://github.com/dotnet/runtime/pull/42359#issuecomment-694490846:

Don't let it stop this PR, but I think these test strings of > 200KB probably should be in the test data repo as they just bloat the repo. Once you've merged them though, that bloat is locked in so it's more of a future suggestion.

From @ericstj in https://github.com/dotnet/runtime/pull/42359#issuecomment-694574240:

You can address the string suggestion in master. We're usually more sensitive about the type of data and how much it changes. Text data is typically OK at somewhat larger sizes if it doesn't change too often, since it compresses really well in git. In fact git uses zlib compression which is based on DEFLATE same as zip used in nupkg. Binary data, especially binary data that changes often, is what we make sure to put in assets packages. Also any large data that would be considered "optional" for some repo consumers. Maybe we could write some guidelines down somewhere :)

Todo:

danmoseley commented 4 years ago

I agree with Eric's guidance

joperezr commented 3 years ago

@layomia are you still planning on addressing this by 6.0? If not, can we adjust the milestone to future then?

ericstj commented 3 years ago

I don't think this meets the bar for 6.0 at this point, let's move it out.