search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.25k stars 4.73k forks source link

Wrong test bash script pattern for composite r2r builds #44190

Open y-yamshchikov opened 4 years ago

y-yamshchikov commented 4 years ago

Following lines lead to IL directory with single .dll file, as a consequence even if test consists of multiple .dlls only one actual component assembly presents in composite-r2r.dll R2R header, and only one component MSIL dll with formal R2R header exists: https://github.com/dotnet/runtime/blob/6b85595a575b33dc2ad109937118ef518ca41d8c/src/tests/Common/CLRTest.CrossGen.targets#L75-L80

If we copy all .dlls of the test instead, and pass all of them as an input to crossgen2, we have composite-r2r.dll with a number of component assemblies in R2R header, and multiple component MSIL assemblies with formal R2R header exist.

@jkotas @alpencolt

Dotnet-GitSync-Bot commented 4 years ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

jkotas commented 4 years ago

cc @trylek