search

dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.26k stars 4.73k forks source link

Build installer tests against the live ref pack #45972

Open jkoritzinsky opened 3 years ago

jkoritzinsky commented 3 years ago

We discovered in #45781 that the installer test assets build against a pre-built ref pack.

Since they build at the end of the build and we want to build them as though they were built against the released product, we should change their build to build against the live ref pack. This way we'll ensure that each test is testing what it should without including any extra roll-forward behaviors that we may accidentally start depending on.

NikolaMilosavljevic commented 3 years ago

[Triage] This should only consume live ref-packs for new release and not in servicing, as those are not reshipped.

NikolaMilosavljevic commented 2 years ago

[Triage] @ViktorHofer is this still needed?

ViktorHofer commented 2 years ago

Yes, afaik they still don't compile against the live targeting pack.

ViktorHofer commented 1 year ago

This is again causing issues when upgrading the TFM (from net7.0 to net8.0): https://github.com/dotnet/runtime/pull/78354/. Will again work-around it for now but we should really fix this.