dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
15.24k stars 4.73k forks source link

[wasm][tests] Tracking issue for errors with `EnableAggressiveTrimming`, for building AOT tests #51249

Open radical opened 3 years ago

radical commented 3 years ago

To enable running tests with AOT, we need to use $(EnableAggressiveTrimming)==true, to reduce the AOT build time. Enabling this introduces some build issues, or test failures though.

To reproduce locally:

  1. $ /dotnet.sh build /p:Configuration=Release /p:TargetOS=Browser /p:TargetArchitecture=wasm /t:Test /path/to/project/file /p:EnableAggressiveTrimming=true
  2. If you are not able to reproduce it with the above, then try building with /p:BuildAOTTestsOnHelix=true to the above command line
  3. If you still cannot reproduce, then ask on the discord channel, as it might be a helix issue

tips:

ghost commented 3 years ago

Tagging subscribers to 'arch-wasm': @lewing See info in area-owners.md if you want to be subscribed.

Issue Details
To enable running tests with AOT, we need to use `$(EnableAggressiveTrimming)==true`, to reduce the AOT build time. Enabling this introduces some build issues, or test failures though. - The main PR for this work is https://github.com/dotnet/runtime/pull/48226 - And a follow up PR (https://github.com/dotnet/runtime/pull/50885) has various fixes for the EAT issues - this adds a build for EAT (and AOT) under `runtime-staging` - the issues are labeled [trimming-for-aot](https://github.com/dotnet/runtime/issues?q=is%3Aissue+is%3Aopen+label%3Atrimming-for-aot) ## To reproduce locally: 1. use the branch from the [second PR](https://github.com/dotnet/runtime/pull/50885) 2. `$ /dotnet.sh build /p:Configuration=Release /p:TargetOS=Browser /p:TargetArchitecture=wasm /t:Test /path/to/project/file /p:EnableAggressiveTrimming=true` 3. If you are not able to reproduce it with the above, then try building with `/p:BuildAOTTestsOnHelix=true` to the above command line 4. If you still cannot reproduce, then ask on the discord channel, as it might be a helix issue ## tips: * make sure to assign the issue to yourself, if you are working on it * You can add `/p:DebuggerSupport=true` to get line numbers
Author: radical
Assignees: -
Labels: `arch-wasm`, `area-Build-mono`, `trimming-for-aot`
Milestone: -
radical commented 3 years ago

cc @steveisok @mdh1418 @SamMonoRT @naricc