Add a rule to specify StringComparer

[xPaw]

Analyzer package

Microsoft.CodeAnalysis.FxCopAnalyzers

Package Version

v2.9.5 (Latest)

assembly.GetTypes().OrderBy(t => t.Namespace)

There are CA1304, CA1305, CA1307 rules which warn about specifying CultureInfo, IFormatProvider, StringComparison.

There is no rule to warn about StringComparer, which also has different behaviours depending on current locale, for example in OrderBy and ThenBy LINQ methods.

[StingyJack]

Would this cover Dictionary<string, T>(StringComparer) also?

[dotnet-issue-labeler[bot]]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @tannergooding See info in area-owners.md if you want to be subscribed.

Issue Details

---

#### Analyzer package [Microsoft.CodeAnalysis.FxCopAnalyzers](https://www.nuget.org/packages/Microsoft.CodeAnalysis.FxCopAnalyzers) #### Package Version v2.9.5 (Latest) #### ```dotnet assembly.GetTypes().OrderBy(t => t.Namespace) ``` There are CA1304, CA1305, CA1307 rules which warn about specifying CultureInfo, IFormatProvider, StringComparison. There is no rule to warn about `StringComparer`, which also has different behaviours depending on current locale, for example in `OrderBy` and `ThenBy` LINQ methods.

Author:	xPaw
Assignees:	-
Labels:	`area-System.Runtime`, `code-analyzer`, `untriaged`
Milestone:	-

[stan-sz]

As per @StingyJack question: it would save so many case-sensitivity bugs in code to have this rule cover Dictionary's constructor...

[symbiogenesis]

Great idea!